build: support python 3.10.0 by iam-frankqiu · Pull Request #40296 · nodejs/node

iam-frankqiu · 2021-10-03T10:42:41Z

Allow python 3.10.0
Fixes: #40294

gengjiawen · 2021-10-03T10:52:08Z

typo: supprot

iam-frankqiu · 2021-10-03T10:55:54Z

typo: supprot

Thank you.

gengjiawen · 2021-10-03T10:57:39Z

typo: supprot

Thank you.

Also in commit message.

iam-frankqiu · 2021-10-03T11:05:40Z

Also in commit message.

Thank you.

richardlau · 2021-10-03T12:08:04Z

Please update the references in BUILDING.md.

iam-frankqiu · 2021-10-03T13:22:54Z

Please update the references in BUILDING.md.

Thank you.

aduh95 · 2021-10-03T14:16:37Z

BUILDING.md

 * `gcc` and `g++` >= 8.3 or newer, or
 * GNU Make 3.81 or newer
-* Python 3.6, 3.7, 3.8, or 3.9 (see note above)
+* Python 3.6, 3.7, 3.8, 3.9 or 3.10 (see note above)


Suggested change

* Python 3.6, 3.7, 3.8, 3.9 or 3.10 (see note above)

* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above)

Since this list is getting pretty long maybe we could just specify a range instead of listing each individual version?

I think 5 versions of the list listing are still acceptable.

aduh95 · 2021-10-03T14:16:46Z

BUILDING.md


 * Xcode Command Line Tools >= 11 for macOS
-* Python 3.6, 3.7, 3.8, or 3.9 (see note above)
+* Python 3.6, 3.7, 3.8, 3.9 or 3.10 (see note above)


Suggested change

* Python 3.6, 3.7, 3.8, 3.9 or 3.10 (see note above)

* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above)

Thank you for your suggestions.

Trott · 2021-10-03T16:11:11Z

@nodejs/python

doc/api/esm.md

cclauss

Let’s hold on this until Python 2.10 is released https://www.python.org/downloads which is scheduled to happen today. It should be tested by at least one Linux, macOS, and Windows user and in our GitHub Actions.

iam-frankqiu · 2021-10-04T07:19:50Z

Let’s hold on this until Python 2.10 is released https://www.python.org/downloads which is scheduled to happen today. It should be tested by at least one Linux, macOS, and Windows user and in our GitHub Actions.

Thank you for your key suggestion. I will add all tests once the 3.10.0 has been released.

cclauss · 2021-10-04T18:38:56Z

Python 3.10.0 is now available https://pythoninsider.blogspot.com/2021/10/python-3100-is-available.html

iam-frankqiu · 2021-10-04T23:49:03Z

Python 3.10.0 is now available https://pythoninsider.blogspot.com/2021/10/python-3100-is-available.html

Yeah. It. seems like the list of GitHub is still not available.

cclauss · 2021-10-05T07:50:08Z

Try again... https://github.com/actions/python-versions/releases

targos · 2021-10-05T08:02:11Z

tools/gyp/.github/workflows/Python_tests.yml

      matrix:
        os: [macos-latest, ubuntu-latest] # , windows-latest]
-        python-version: [3.6, 3.7, 3.8, 3.9]
+        python-version: [3.6, 3.7, 3.8, 3.9, 3.10]


tools/gyp changes should be done in https://github.com/nodejs/gyp-next

Testing with nodejs/gyp-next#127 ... The first commit demonstrates that if 3.10 is not quoted (i.e. "3.10") in the yaml then actions/setup-python will attempt (and fail) to load Python 3.1 instead of 3.10.

tools/gyp changes should be done in https://github.com/nodejs/gyp-next

Thank you.

PR-URL: nodejs#40296 Fixes: nodejs#40294 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #40296 Fixes: #40294 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #40296 Backport-PR-URL: #40689 Fixes: #40294 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: nodejs#40296 Fixes: nodejs#40294 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Oct 3, 2021

iam-frankqiu changed the title ~~build: supprot python 3.10.0~~ build: support python 3.10.0 Oct 3, 2021

iam-frankqiu force-pushed the supportPython310 branch from 5cd792d to 4007ded Compare October 3, 2021 11:04

gengjiawen approved these changes Oct 3, 2021

View reviewed changes

aduh95 reviewed Oct 3, 2021

View reviewed changes

jasnell approved these changes Oct 3, 2021

View reviewed changes

richardlau approved these changes Oct 3, 2021

View reviewed changes

Trott added the python PRs and issues that require attention from people who are familiar with Python. label Oct 3, 2021

iam-frankqiu requested review from aduh95 and mscdex October 3, 2021 17:02

Ayase-252 reviewed Oct 4, 2021

View reviewed changes

doc/api/esm.md Show resolved Hide resolved

iam-frankqiu force-pushed the supportPython310 branch from ee8c753 to c3d5917 Compare October 4, 2021 06:54

cclauss requested changes Oct 4, 2021

View reviewed changes

iam-frankqiu force-pushed the supportPython310 branch from c3d5917 to 3bff9b5 Compare October 4, 2021 07:01

iam-frankqiu requested a review from Ayase-252 October 4, 2021 07:13

iam-frankqiu requested a review from cclauss October 4, 2021 23:30

targos reviewed Oct 5, 2021

View reviewed changes

cclauss mentioned this pull request Oct 5, 2021

test: Add Python 3.10 to GitHub Actions nodejs/gyp-next#127

Merged

richardlau added lts-watch-v14.x and removed dont-land-on-v14.x labels Nov 1, 2021

richardlau mentioned this pull request Nov 1, 2021

[v14.x] Backport Python 3.10 compatibility patches #40689

Closed

richardlau added backport-open-v14.x and removed lts-watch-v14.x labels Nov 1, 2021

addaleax mentioned this pull request Nov 19, 2021

Boxednode fails on Windows with Node v16.x mongodb-js/boxednode#20

Closed

richardlau added backported-to-v14.x and removed backport-open-v14.x labels Nov 25, 2021

richardlau mentioned this pull request Nov 25, 2021

v14.18.2 proposal #40969

Merged

qwell mentioned this pull request Nov 25, 2021

tools: patch jinja2 for Python 3.10 compat citizenfx/node#3

Closed

4 tasks

targos mentioned this pull request Nov 26, 2021

v17.2.0 release proposal #40983

Merged

qwell mentioned this pull request Dec 3, 2021

tools: patch jinja2 for Python 3.10 compat citizenfx/node#4

Closed

	* Python 3.6, 3.7, 3.8, 3.9 or 3.10 (see note above)
	* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above)

Uh oh!

Conversation

iam-frankqiu commented Oct 3, 2021

Uh oh!

gengjiawen commented Oct 3, 2021

Uh oh!

iam-frankqiu commented Oct 3, 2021

Uh oh!

gengjiawen commented Oct 3, 2021

Uh oh!

iam-frankqiu commented Oct 3, 2021

Uh oh!

richardlau commented Oct 3, 2021

Uh oh!

iam-frankqiu commented Oct 3, 2021

Uh oh!

aduh95 Oct 3, 2021

Choose a reason for hiding this comment

Uh oh!

mscdex Oct 3, 2021

Choose a reason for hiding this comment

Uh oh!

iam-frankqiu Oct 3, 2021

Choose a reason for hiding this comment

Uh oh!

aduh95 Oct 3, 2021

Choose a reason for hiding this comment

Uh oh!

iam-frankqiu Oct 3, 2021

Choose a reason for hiding this comment

Uh oh!

Trott commented Oct 3, 2021

Uh oh!

Uh oh!

cclauss left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iam-frankqiu commented Oct 4, 2021

Uh oh!

cclauss commented Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iam-frankqiu commented Oct 4, 2021

Uh oh!

cclauss commented Oct 5, 2021

Uh oh!

targos Oct 5, 2021

Choose a reason for hiding this comment

Uh oh!

cclauss Oct 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iam-frankqiu Oct 5, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

cclauss left a comment •

edited

Loading

cclauss commented Oct 4, 2021 •

edited

Loading

cclauss Oct 5, 2021 •

edited

Loading